Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]: update comments for github_branch_protection in case of push_restrictions #1945

Merged
merged 4 commits into from
Oct 10, 2023
Merged

[docs]: update comments for github_branch_protection in case of push_restrictions #1945

merged 4 commits into from
Oct 10, 2023

Conversation

Nmishin
Copy link
Contributor

@Nmishin Nmishin commented Oct 7, 2023

Resolves #1841

Before the change?

  • Docks have a wrong comments

After the change?

  • Docks have a right comments about push_restrictions, and also note for the right access rights.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@macetw
Copy link
Contributor

macetw commented Oct 9, 2023

Awesome, Mishin, but I'd like to suggest your examples include a mix of team/user. This was the original problem with the documentation, that it was shown as a bug. But In your examples, it isn't really demonstrating the way this can be overcome.

Thanks for working this!!

@macetw
Copy link
Contributor

macetw commented Oct 9, 2023

Added suggestions. Thanks again, Mishin!

@Nmishin
Copy link
Contributor Author

Nmishin commented Oct 9, 2023

macetw, thank you for review!
I added your commits, please check, it looks better now?

macetw
macetw approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@macetw macetw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Mishin!

@nickfloyd nickfloyd added Type: Documentation Improvements or additions to documentation hacktoberfest Issues for participation in Hacktoberfest labels Oct 10, 2023
@nickfloyd nickfloyd changed the title Docs: update comments for github_branch_protection in case of push_restrictions [docs]: update comments for github_branch_protection in case of push_restrictions Oct 10, 2023
nickfloyd
nickfloyd approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Nmishin thank you for these contributions! ❤️

@nickfloyd nickfloyd merged commit e126a43 into integrations:main Oct 10, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macetw macetw macetw approved these changes

@nickfloyd nickfloyd nickfloyd approved these changes

Assignees
No one assigned
Labels
hacktoberfest Issues for participation in Hacktoberfest Type: Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS]: Docs for github_branch_protection restrictions are inaccurate
3 participants
@Nmishin @macetw @nickfloyd